Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media attribute to source tag in file player #1269

Conversation

marcus-aemilius
Copy link
Contributor

When using react-player's file player in a typescript project, I noticed that the media attribute is missing in the type definitions. (When working around the types, the media attribute shows up in the <video> element due to the spreading operation in the code.)

Although, unfortunately, the media attribute seems to be ignored by some browsers, it's still part of HTML 5. I am therefore suggesting to add it to the type definitions and fix the functionality by the test I extended.

@cookpete cookpete merged commit 0e0c18e into cookpete:master Oct 26, 2021
@cookpete
Copy link
Owner

Published in 2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants