Add media attribute to source tag in file player #1269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using react-player's file player in a typescript project, I noticed that the media attribute is missing in the type definitions. (When working around the types, the media attribute shows up in the
<video>
element due to the spreading operation in the code.)Although, unfortunately, the media attribute seems to be ignored by some browsers, it's still part of HTML 5. I am therefore suggesting to add it to the type definitions and fix the functionality by the test I extended.